Add basic vcard validation#25905
Closed
DeepDiver1975 wants to merge 1 commit into
Closed
Conversation
|
@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975 to be a potential reviewer |
DeepDiver1975
force-pushed
the
verify-vcard-on-import
branch
from
5c3bdf2 to
3f3d20d
Compare
Contributor
|
A unit test would be nice with some broken vcards |
Member
Author
|
If we don't want to walk the backport path: a 'simple' upgrade to sabre 3.2 is enough for 9.2 - see #26115 |
Member
Author
|
I'm closing this in favor of #26115 - 9.2 will add vcard validation on import |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/owncloud/contact/issues/488
alternative approach would be to fix this upstream - https://github.com/fruux/sabre-dav/issues/874#issuecomment-241500878