Allow uploading empty files#26113
Merged
Merged
Conversation
|
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke, @butonic and @luckydonald to be potential reviewers |
Contributor
|
Works 👍 |
Contributor
|
👍 tested with empty files and directories |
Contributor
Author
|
I'll backport this after the releases |
This was referenced Sep 19, 2016
Contributor
Author
LukasReschke
pushed a commit
to nextcloud/server
that referenced
this pull request
Sep 26, 2016
Downstreaming of owncloud/core#26113 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
butonic
pushed a commit
that referenced
this pull request
Jan 18, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow upload zero sized files in the web UI.
It didn't work before because there was a check for directory uploads in browsers that don't support it, the check relied on zero file size and gave false positives when uploading files with no known mime types.
Related Issue
Fixes #19116
Motivation and Context
Because people sometimes upload multiple files and have an empty file in the list, they want it to go through too.
How Has This Been Tested?
Create two local empty files "test.txt" and "test.blubb". Upload both with drag and drop and the upload dialog.
Before: test.blubb doesn't go through
After: it does!
Types of changes
Checklist:
Backports:
Please review @SergioBertolinSG @michaelstingl @VicDeo @DeepDiver1975