App dependencies are now analysed on app enable as well - not only on app install.

[DeepDiver1975]

Description

App dependencies can now evaluated on enable as well.

Motivation and Context

Let's say the system environment was okay on installation of an app.
Then the app is disabled for some time and in between the system environment is changed.
After re-enabling the app we would render the system unstable.

How Has This Been Tested?

Add a dependency to an installed but disabled app - e.g.

    <database>mongodb</database>

Now enable the app and see it fail

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[mention-bot]

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @icewind1991 and @nickvergessen to be potential reviewers.

[PVince81]

Tested by enabling on the CLI with mismatch requirements because the web UI doesn't allow it. Works 👍
Also checked that master didn't do the check with "occ app:enable".

[DeepDiver1975]

@PVince81 @butonic do we agree on backporting? THX

[PVince81]

I'd say backport to 9.1 but no further, unless really critical

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.