Skip to content

Fix mock warning in some FS tests#26464

Merged
DeepDiver1975 merged 1 commit into
masterfrom
tests-fixmockwarnings
Oct 24, 2016
Merged

Fix mock warning in some FS tests#26464
DeepDiver1975 merged 1 commit into
masterfrom
tests-fixmockwarnings

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

Because we don't like warnings like:

16:30:08 1) Test\Files\FilesystemTest::testUserNameCasing
16:30:08 PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead
16:30:08 
16:30:08 2) Test\Files\Node\RootTest::testGetUserFolder
16:30:08 PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

@DeepDiver1975 @tomneedham

@PVince81 PVince81 added this to the 9.2 milestone Oct 24, 2016
@mention-bot

Copy link
Copy Markdown

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @DeepDiver1975 and @nickvergessen to be potential reviewers.

@phisch

phisch commented Oct 24, 2016

Copy link
Copy Markdown
Contributor

👍

@DeepDiver1975 DeepDiver1975 merged commit 6aebb84 into master Oct 24, 2016
@DeepDiver1975 DeepDiver1975 deleted the tests-fixmockwarnings branch October 24, 2016 20:17
elie195 pushed a commit to elie195/core that referenced this pull request Mar 23, 2017
@lock

lock Bot commented Aug 4, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants