Skip to content

make object prefix configurable#26498

Merged
PVince81 merged 1 commit into
masterfrom
feature-customizable-objectstore-object-prefix
Oct 28, 2016
Merged

make object prefix configurable#26498
PVince81 merged 1 commit into
masterfrom
feature-customizable-objectstore-object-prefix

Conversation

@butonic

@butonic butonic commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

Description

Allow changing the object prefix.

Related Issue

Not all objectstorages will allow ':' in the object name, see minio/minio#2954

Motivation and Context

easier testing, objectstore incompatability

How Has This Been Tested?

local minio instance, adding the param to the swift based test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot

Copy link
Copy Markdown

@butonic, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @LukasReschke and @carlaschroder to be potential reviewers.

@butonic butonic force-pushed the feature-customizable-objectstore-object-prefix branch from b4e1178 to c76605e Compare October 27, 2016 12:31
@butonic

butonic commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

failing tests unrelated

@PVince81 PVince81 added this to the 9.2 milestone Oct 28, 2016
@PVince81

Copy link
Copy Markdown
Contributor

Makes sense 👍

@PVince81 PVince81 merged commit 850ad9c into master Oct 28, 2016
@PVince81 PVince81 deleted the feature-customizable-objectstore-object-prefix branch October 28, 2016 08:20
@butonic

butonic commented Mar 8, 2017

Copy link
Copy Markdown
Contributor Author

fixes #17147

'username' => '$user',
'password' => '$pass',
'container' => 'owncloud-autotest$EXECUTOR_NUMBER',
'objectPrefix' => 'autotest$EXECUTOR_NUMBER:oid:urn:',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent 😉

@PVince81

PVince81 commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

👍 makes sense

@PVince81

PVince81 commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

huh, what am I reading

@PVince81

PVince81 commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

ah ok, you just added the link... makes sense 😄

@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants