Fix colon followed by number

[PVince81]

Description

• TODO: upgrade sabre/uri once Colon ':' in urls causing problems sabre-io/uri#9 is released
• adds integration test: Colon in folder name followed by a number creates fatal error #25479

Related Issue

Fixes #25479

Motivation and Context

How Has This Been Tested?

Just run the integration test

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Backports:

• stable9.1
• stable9

@owncloud/qa

[mention-bot]

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @DeepDiver1975 and @davitol to be potential reviewers.

[SergioBertolinSG]

@PVince81 will you upgrade sabre/uri on this PR ?

This one is already merged sabre-io/uri#13

Tests are ok 👍

[PVince81]

Yes, I'll upgrade sabre-uri in this PR.

[PVince81]

Added commit with the upgrade, let's see what CI says

[PVince81]

@DeepDiver1975 tests fail because of expected VObject version. Two possible solutions:

1. We don't update vobject in this PR
   or
2. Adjust test to expect the new version

Since this is on master I think it's fine to update vobject for now, so I'll adjust the tests

[PVince81]

Oh well... while rebasing I had to do a composer update sabre/uri anyway which seems to have only updated sabre/uri, so we'll go with that.

[PVince81]

All tests passed now, merge ? @SergioBertolinSG @DeepDiver1975

[SergioBertolinSG]

👍

[PVince81]

To backport:

• stable9.1
  • backport tests
  • backport lib update to 3rdparty repo
  • adjust 3rdparty commit
• stable9:
  • backport tests
  • backport lib update to 3rdparty repo
  • adjust 3rdparty commit

[PVince81]

@SergioBertolinSG can you backport the tests ?
I'll take care of the 3rdparty repo if we see them failing.

[SergioBertolinSG]

Sure.

[SergioBertolinSG]

• Stable9 - [Stable9] Add integration test for creating folder with colon #26815
• Stable9.1 - [Stable9.1] Add integration test for creating folder with colon #26814

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.