Respect home folder setting in encryption

[DeepDiver1975]

Description

In case the user backend defines the user home folder to be in a different place then data/$uid encryption will fail to find the keys.

How Has This Been Tested?

1. use ldap with special home folder rule
2. enable encryption
3. share an encrypted file with another user
4. 💥

Could not encrypt file for _8060: Public Key missing for user: _8060

In case you cannot setup an ldap use this patch:

Index: lib/private/User/Database.php
I===================================================================
--- lib/private/User/Database.php	(revision fa7a82fe0526645e00fed51d5f9ce869b2b67660)
+++ lib/private/User/Database.php	(revision )
@@ -280,6 +280,7 @@
 	 */
 	public function getHome($uid) {
 		if ($this->userExists($uid)) {
+			$uid = md5($uid);
 			return \OC::$server->getConfig()->getSystemValue("datadirectory", \OC::$SERVERROOT . "/data") . '/' . $uid;
 		}

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[mention-bot]

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81 to be a potential reviewer.

[PVince81]

Weird, normally when using views the user's home folder is supposed to be already mounted there.
I'll have a closer look... Could also be that initMountPoints was missing so the mount is not there.

[DeepDiver1975]

Weird, normally when using views the user's home folder is supposed to be already mounted there.

As far as I can tell the user's folder is properly mounted but the encryption code tries to access the keys with the uid - ignoring the home folder setting.
There are many more locations in the code where this fails .....

[felixboehm]

👍 confirmed to work so far

[felixboehm]

I would expect $home to be "root_dir . $home"

[PVince81]

Let's close in favor of the alternative: #26820

Apps should not have to care about getHome, they work on the existing OC virtual filesystem where the user's home must be mounted. However the subtle thing is that even if we forgot to mount the user's home, if the user id matches the user id on disk, it magically works because the folder has the same name... That's how such issues sneak in.

[PVince81]

👎

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.