Skip to content

Update handlebars#26841

Merged
PVince81 merged 1 commit into
masterfrom
update-handlebars
Dec 22, 2016
Merged

Update handlebars#26841
PVince81 merged 1 commit into
masterfrom
update-handlebars

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

We need to have the same node + bower version of handlebars to be able
to precompile templates.

Also I updated bower since it prompted me to do it 😄

I quickly rechecked the files sidebar and some of the panels like sharing and they still work (they use handlebars).

@DeepDiver1975 @VicDeo @jvillafanez @felixheidecke @PhilippSchaffrath

@PVince81 PVince81 added this to the 10.0 milestone Dec 19, 2016
@mention-bot

Copy link
Copy Markdown

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 and @Maddoc42 to be potential reviewers.

We need to have the same node + bower version of handlebars to be able
to precompile templates.
@phisch

phisch commented Dec 22, 2016

Copy link
Copy Markdown
Contributor

The changes are okay, but i am wondering why we are using both bower and node package manager?
How about we kill either one?
From the looks of it most stuff is available in either one of both, the rest should not be too hard to switch.

👍 for the changes though

@PVince81

Copy link
Copy Markdown
Contributor Author

@PhilippSchaffrath raised #26863 to discuss it.
From my limited knowledge of npm with JS client libs and also my knowledge how inflexible OC can be, it might not be possible. Let's discuss in the ticket.

@PVince81
PVince81 merged commit 3e9d2d5 into master Dec 22, 2016
@PVince81
PVince81 deleted the update-handlebars branch December 22, 2016 09:08
@lock

lock Bot commented Aug 4, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants