Skip to content

Don't mount user home with alternate keys root#26937

Merged
PVince81 merged 1 commit into
masterfrom
enc-keyroot-fix
Jan 16, 2017
Merged

Don't mount user home with alternate keys root#26937
PVince81 merged 1 commit into
masterfrom
enc-keyroot-fix

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

Description

When encryption keys are stored outside the user's homes, there is no
need to mount said homes.

Related Issue

Follow up of #26917.
Discovered while working on #26935.
This only fixes the "alternative key storage" case from #26935 and might also improve the performance a bit as we don't need to mount the user's homes.

Motivation and Context

Don't do unnecessary stuff.
But also I feel that this was missing from #26917

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Please review @jvillafanez @SergioBertolinSG

When encryption keys are stored outside the user's homes, there is no
need to mount said homes.
@mention-bot

Copy link
Copy Markdown

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 to be a potential reviewer.

@jvillafanez

Copy link
Copy Markdown
Member

Hmmm, does the alternate root refer to a full path on the host? If so, it should be fine, although I'd like another kind of flag for this.

@PVince81

Copy link
Copy Markdown
Contributor Author

@jvillafanez the logic is as follows: empty string path means "no alternative root".
When a path is specified (full path on host, or relative to data dir (I forgot which)), then it uses that one.

Indeed a flag would be better here to make it clearer.

@PVince81 PVince81 added this to the 10.0 milestone Jan 16, 2017
@PVince81
PVince81 merged commit 703496c into master Jan 16, 2017
@PVince81
PVince81 deleted the enc-keyroot-fix branch January 16, 2017 18:16
@lock

lock Bot commented Aug 4, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants