Don't mount user home with alternate keys root#26937
Merged
Merged
Conversation
When encryption keys are stored outside the user's homes, there is no need to mount said homes.
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 to be a potential reviewer. |
This was referenced Jan 13, 2017
Member
|
Hmmm, does the alternate root refer to a full path on the host? If so, it should be fine, although I'd like another kind of flag for this. |
Contributor
Author
|
@jvillafanez the logic is as follows: empty string path means "no alternative root". Indeed a flag would be better here to make it clearer. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When encryption keys are stored outside the user's homes, there is no
need to mount said homes.
Related Issue
Follow up of #26917.
Discovered while working on #26935.
This only fixes the "alternative key storage" case from #26935 and might also improve the performance a bit as we don't need to mount the user's homes.
Motivation and Context
Don't do unnecessary stuff.
But also I feel that this was missing from #26917
How Has This Been Tested?
NoUserExceptionwhen deleting a user in this "alternate keys storage root" setup.Screenshots (if appropriate):
Types of changes
Checklist:
Please review @jvillafanez @SergioBertolinSG