Skip to content

Sharing dialog: Names sorting is case sensitive #25971#26950

Merged
PVince81 merged 2 commits into
owncloud:masterfrom
IljaN:25971_sharing_diag_case_insensetive
Feb 1, 2017
Merged

Sharing dialog: Names sorting is case sensitive #25971#26950
PVince81 merged 2 commits into
owncloud:masterfrom
IljaN:25971_sharing_diag_case_insensetive

Conversation

@IljaN

@IljaN IljaN commented Jan 17, 2017

Copy link
Copy Markdown
Contributor

Description

Using natural sort for sharees dropdown.

Related Issue

#25971

Motivation and Context

Same sorting method across all dropdowns.

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81

Copy link
Copy Markdown
Contributor

@IljaN can you add a JS unit test for this ? You can run the JS tests using make test-js (requires a local node js install)

@DeepDiver1975 DeepDiver1975 added this to the 10.0 milestone Jan 23, 2017
@IljaN

IljaN commented Feb 1, 2017

Copy link
Copy Markdown
Contributor Author

@PVince81 Ping :)

@PVince81

PVince81 commented Feb 1, 2017

Copy link
Copy Markdown
Contributor

Looks good 👍

@lock

lock Bot commented Aug 4, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants