Emit postSetEnabled for user

[VicDeo]

Description

Implements user enabled/disabled event

Related Issue

#23970

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[VicDeo]

@PVince81 is it good enough?

[PVince81]

@VicDeo yeah. A unit test would be nice if possible.

[VicDeo]

@PVince81 possible. Added.

[PVince81]

👍

[DeepDiver1975]

This will not help. The emitter is on the user object. In order to consume the event a listener needs to be attached to each and every user. Pointless.

This is why the whole emitter concept is 💩

Please use the EventDispatcher - THX

[VicDeo]

@DeepDiver1975

This will not help.

Untrue. Tested both auto and manually, and works. ;)

Please use the EventDispatcher - THX

OK

[DeepDiver1975]

Untrue. Tested both auto and manually, and works. ;)

show me the code which will listen to enabling of all users - good luck 😉

[VicDeo]

@DeepDiver1975 enabling / disabling is NOT a backend method anyway:

$this->config->setUserValue($this->uid, 'core', 'enabled', $enabled);

It can be done on per user level only. Because backend knows nothing about this operation.

With or without EventDispatcher IDK how to do it for all users ATM.

[PVince81]

replace this with something like:

	$eventDispatcher = \OC::$server->getEventDispatcher();
	$eventDispatcher->dispatch('OC\User::postSetEnabled', $this');

then to listen, an app just does this:

$eventDispatcher = \OC::$server->getEventDispatcher();
$eventDispatcher->addListener(
	'OC\User::postSetEnabled',
	function(IUser $user) {
             // ...
        });

(the param of the callback might be something else, I don't remember exactly)

[PVince81]

or without EventDispatcher IDK how to do it for all users ATM.

@VicDeo see https://github.com/owncloud/core/pull/26984/files#r97399288

[VicDeo]

@PVince81 Ok, let it be EventDispatcher.

[DeepDiver1975]

please don't use the event listener from the container - this can cause side effects.
It should be enough to use a mock and assert on the dispatch function

[DeepDiver1975]

@VicDeo please take care so that we can merge this one - THX

[VicDeo]

to do so I need to inject EventDispatcher next to \OC\Hooks\Emitter 😭

[DeepDiver1975]

is $eventDispatcher ever passed into this ctor?

[DeepDiver1975]

@VicDeo ^^^

[VicDeo]

@DeepDiver1975 passed now.

[PVince81]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.