Skip to content

Added a file to local storage for checksum tests#27227

Merged
PVince81 merged 1 commit into
masterfrom
intttest-add-content-to-localstorage
Mar 1, 2017
Merged

Added a file to local storage for checksum tests#27227
PVince81 merged 1 commit into
masterfrom
intttest-add-content-to-localstorage

Conversation

@SergioBertolinSG

Copy link
Copy Markdown
Contributor

@PVince81 Pull request for #27097 (comment).

Is this what you need?

@mention-bot

Copy link
Copy Markdown

@SergioBertolinSG, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81 and @DeepDiver1975 to be potential reviewers.

@PVince81

Copy link
Copy Markdown
Contributor

Partly, yes. But I'm afraid that the file will not regenerate between tests.

For the checksums, we can only ever do a single test on this file, downloading it and seeing that the checksum is there. However if we want to do a second similar test, we can't, because we can't reset the file back to be "a new file that OC doesn't know about yet".

@SergioBertolinSG

Copy link
Copy Markdown
Contributor Author

OK, so I'll add a function to create files dinamically.

To use something like this as step:
"create a file "testfile.txt" directly on storage"

@SergioBertolinSG SergioBertolinSG force-pushed the intttest-add-content-to-localstorage branch from 66a3811 to 11aa00e Compare March 1, 2017 10:13
@PVince81

PVince81 commented Mar 1, 2017

Copy link
Copy Markdown
Contributor

Great 👍

@PVince81 PVince81 merged commit 547c95e into master Mar 1, 2017
@PVince81 PVince81 deleted the intttest-add-content-to-localstorage branch March 1, 2017 15:23
@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants