Modifying comments tests

[SergioBertolinSG]

Refactoring and preparation for adding more tests related with comments.

[mention-bot]

@SergioBertolinSG, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @DeepDiver1975 and @davitol to be potential reviewers.

[PVince81]

Had a quick glance, looks good 👍

[mrow4a]

Awesome, lets make CommentsApp great again!

[SergioBertolinSG]

This step is commented because it is failing:

https://github.com/owncloud/core/pull/27446/files#diff-6692878a78a86bbf0b3daf9e5e6522deR104

Raised here: #27455

[PVince81]

17:58:15 --- FeatureContext has missing steps. Define them with these snippets:
17:58:15 
17:58:15     /**
17:58:15      * @Given As :arg1 sending :arg2 to :arg3 with
17:58:15      */
17:58:15     public function asSendingToWith($arg1, $arg2, $arg3, TableNode $table)
17:58:15     {
17:58:15         throw new PendingException();
17:58:15     }

[SergioBertolinSG]

Apparently tags tests depended on a comments function. I have moved it there.
Tags will require the same changes as comments. But not to be done in this PR.

[PVince81]

would be safer to XML-encode this string to avoid injection.
Fortunately this is just test code

[SergioBertolinSG]

Do you mean escape? Is htmlspecialchars fine for this?

[PVince81]

Fix the XML encode issue and this is good to go 👍

[SergioBertolinSG]

The property {http://owncloud.org/ns}comments-unread is not being included.

Jenkins failure:

Traza

And the single response should contain a property "{http://owncloud.org/ns}comments-unread" with value "0":

Cannot find property "{http://owncloud.org/ns}comments-unread" with "0"

Seems to be a bug introduced in #27339

cc @mrow4a

[mrow4a]

@SergioBertolinSG Did you check this scenario "by hand" first? Why this scenario talks about folder if this is a file?

[SergioBertolinSG]

I checked it locally and it returned only the other two properties.

[mrow4a]

Normal propfind works. Will look at it later, but this might not be working previously also, dont see a point in the code yet.

[mrow4a]

@SergioBertolinSG this should be separate PR to this branch, isnt it?

[SergioBertolinSG]

@SergioBertolinSG this should be separate PR to this branch, isnt it?

Ok, that failing test the only thing stopping this Pr to be merged now.

[PVince81]

@mrow4a please fix on this branch. CI will tell whether it was actually fixed.
Thanks

[mrow4a]

It occured, that when targeting single file with PROPFIND, it was returning null instead of 0, and requirement is to return the property. In web, it does not do propfinds to single files for unread, but this fix was needed anyways.

[PVince81]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.