Skip to content

[stable9] Properly handle deleted users in UserMountCache#27489

Merged
PVince81 merged 1 commit into
stable9from
stable9-usermountcache-deletedusers
Apr 20, 2017
Merged

[stable9] Properly handle deleted users in UserMountCache#27489
PVince81 merged 1 commit into
stable9from
stable9-usermountcache-deletedusers

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

Backport of #27028 to stable9

When encountering entries from a deleted user, discard such entries.
@PVince81 PVince81 added this to the 9.0.9 milestone Mar 24, 2017
@mention-bot

Copy link
Copy Markdown

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @nickvergessen and @LukasReschke to be potential reviewers.

@PVince81

Copy link
Copy Markdown
Contributor Author

Hmm, seems I can't reproduce the issue using #27012 (comment) on stable9. And the fix doesn't clean up the bogus entry.

Might as well close this. At least there is no visible exception or issue.

@PVince81 PVince81 closed this Mar 27, 2017
@PVince81 PVince81 reopened this Mar 27, 2017
@PVince81

Copy link
Copy Markdown
Contributor Author

hmm, not reproducible on stable9.1 either... needs further research

@PVince81

Copy link
Copy Markdown
Contributor Author

Retested this, it works.

Steps here #27012 (comment) and require the activity app to be enabled.

Please note that the symptoms on stable9 are different than in the original issue.
In the original issue there is a clear error in the UI when commenting, but on stable9 the comment is posted and the error appears in the log only. Also, no activity is posted for the comment on stable9.
After this fix, no error in log and activity comment is posted properly.

Please review @jvillafanez @DeepDiver1975 @butonic (<= it was based on your patch)

@jvillafanez

Copy link
Copy Markdown
Member

👍

@PVince81 PVince81 modified the milestones: 9.0.10, 9.0.9 Apr 13, 2017
@PVince81
PVince81 merged commit f2a4318 into stable9 Apr 20, 2017
@PVince81
PVince81 deleted the stable9-usermountcache-deletedusers branch April 20, 2017 14:53
@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants