Dispatch upgradeAppStoreApps event#27648
Merged
Merged
Conversation
PVince81
reviewed
Apr 18, 2017
| // if (Installer::isUpdateAvailable($app)) { | ||
| // $ocsId = \OC::$server->getConfig()->getAppValue($app, 'ocsid', ''); | ||
| // | ||
| // $this->emit('\OC\Updater', 'upgradeAppStoreApp', [$app]); |
Contributor
There was a problem hiding this comment.
keep old events for backward compatibility ?
Contributor
Author
There was a problem hiding this comment.
@PVince81 it was not me, who commented that out. IIRC it was commented when app management part was stripped from core
Contributor
|
apart from that looks good to me. still WIP ? |
Contributor
Author
|
@PVince81 I haven't tested it yet. I'm not used to supply untested code |
Contributor
|
would still be good to keep the old hook, unless you think it's private and not used anywhere. if that's the case, then 👍 |
VicDeo
changed the title
Contributor
Author
|
@PVince81 It has a listener in |
9 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.