UI tests - autocomplete sharing#27933
Conversation
|
I had a go at resolving the conflicts, but it is not happy yet. I will look again in a while... |
|
this is branched off from the file renaming. Let's have the autocomplete stuff in here only |
individual-it
changed the title
individual-it
force-pushed
the
ui-test-autocomplete-sharing
branch
3 times, most recently
from
e8bc9d8 to
867cdad
Compare
individual-it
changed the title
individual-it
force-pushed
the
ui-test-autocomplete-sharing
branch
from
867cdad to
1a52857
Compare
individual-it
force-pushed
the
ui-test-autocomplete-sharing
branch
from
fdc4a26 to
65a486e
Compare
individual-it
force-pushed
the
ui-test-autocomplete-sharing
branch
from
65a486e to
29c2e46
Compare
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
I think just little things that are not functional.
This code should work fine.
| protected $shareWithFieldXpath = ".//*[contains(@class,'shareWithField')]"; | ||
| protected $shareWithTooltipXpath = "/..//*[@class='tooltip-inner']"; | ||
| protected $shareWithAutocompleteListXpath = ".//ul[contains(@class,'ui-autocomplete')]"; | ||
| protected $autocompleItemsTextXpath = "//*[@class='autocomplete-item-text']"; |
There was a problem hiding this comment.
s/autocompleItemsTextXpath/autocompleteItemsTextXpath
in all places
| Then a tooltip with the text "No users or groups found for doesnotexist" should be shown near the share-with-field | ||
| And the autocomplete list should not be displayed | ||
|
|
||
| Scenario: autocompletion of a pattern that matches regular existing users but also a user whith whom the item is already shared (folder) |
There was a problem hiding this comment.
s/whith/with
I don't think that scenario descriptions have to match any code, so this will have no other places to fix.
| public function theFileFolderIsSharedWithTheUser($folder, $user) | ||
| { | ||
| $this->filesPage->waitTillPageIsloaded($this->getSession()); | ||
| $this->sharingDialog= $this->filesPage->openSharingDialog( |
There was a problem hiding this comment.
No space before =
I guess these can be tidied up.
| public function theShareDialogForTheFileFolderIsOpen($name) | ||
| { | ||
| $this->filesPage->waitTillPageIsloaded($this->getSession()); | ||
| $this->sharingDialog= $this->filesPage->openSharingDialog( |
| * @return SharingDialog | ||
| */ | ||
| public function openSharingDialog ($name, Session $session) | ||
| { |
There was a problem hiding this comment.
I guess we be consistent and should put spaces before and after =
|
I feel this is now ready to go. |
|
@DeepDiver1975 and others, as well as adding new tests this makes infrastructure for generally dealing with fields that have autocomplete. In the autocomplete case the underlying AJAX only starts when the user has stopped typing for "a bit". So we need to check in the testing that the AJAX has started and then finished before moving on to check that the desired matching item(s) is in the list. Thus there are new functions here to deal with that. The existing waiting loops have also been changed so that they wait more accurately only until the real requested timeout (the previous behaviour with the counter sometimes resulted in a total wait time much greater than asked for, which delayed test completion if timeout conditions happened much) For some reason Jenkins seems to have never even tried to start. |
|
Jenkins did its thing with this a while ago. Merging now. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
Description
UI test to test the user autocompletion as per QA plan https://github.com/owncloud/QA/blob/master/Server/Test_Plan_Sharees.md
Related Issue
https://github.com/owncloud/QA/blob/master/Server/Test_Plan_Sharees.md
Motivation and Context
make Test plan run automatically
https://github.com/owncloud/QA/blob/master/Server/Test_Plan_Sharees.md
How Has This Been Tested?
run the tests in Chrome on local machine
Screenshots (if appropriate):
Types of changes
Checklist: