Make rename file tooltip error text change

[phil-davis]

Description

Related Issue

#27864

Motivation and Context

As the reason that the file name is invalid changes, the displayed text does not change.
The user needs to see an up-to-date error reason.

How Has This Been Tested?

1. Create 2 files in a folder
2. Rename one file, first blank out the whole file name and file type. "File name cannot be empty" is displayed in the tooltip -good.
3. Now type a name that exactly matches the name of the other file in the folder. The tooltip displays again, but it still says "File name cannot be empty".

After this fix, at step (3) the tooltip pops up and says "file.type already exists"
and as you blank out the filename, put a single "." etc, the tooltip text changes.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

@individual-it already has a failing UI test for this case in #27872 and needs this fix to make them pass.

[individual-it]

confirming: with this fix the renaming tests in #27872 are passing

[phil-davis]

@PVince81 this is just a little 1-liner to fix. Does this look good to you?
It would be nice to have it fixed so @individual-it new tests for renaming files will work.

I am having a look at other places in the code that use input.attr('title', zzz) and .tooltip stuff. I will make a separate PR to fix whatever else I find.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.