Skip to content

Preserve 15 permissions when creating link shares#28060

Merged
PVince81 merged 1 commit into
masterfrom
fix-create-link-share-perms
Jun 1, 2017
Merged

Preserve 15 permissions when creating link shares#28060
PVince81 merged 1 commit into
masterfrom
fix-create-link-share-perms

Conversation

@PVince81

@PVince81 PVince81 commented Jun 1, 2017

Copy link
Copy Markdown
Contributor

Description

Preserve 15 permissions when creating link shares

Related Issue

Fixes #28057

Motivation and Context

How Has This Been Tested?

Integration test and unit test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Please review @SamuAlfageme @jvillafanez @DeepDiver1975.

Yes, this code is super-ugly, there are two separate methods for create and update... needs refactoring one day.

@PVince81 PVince81 merged commit 8e3ad19 into master Jun 1, 2017
@PVince81 PVince81 deleted the fix-create-link-share-perms branch June 1, 2017 15:00
@PVince81

PVince81 commented Jun 1, 2017

Copy link
Copy Markdown
Contributor Author

stable10: #28065

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New share link forgets "Allow editing" permissions

3 participants