Skip to content

Removed before and after scenarios to speed up tests#28093

Merged
SergioBertolinSG merged 3 commits into
masterfrom
inttest-making-them-faster
Jun 12, 2017
Merged

Removed before and after scenarios to speed up tests#28093
SergioBertolinSG merged 3 commits into
masterfrom
inttest-making-them-faster

Conversation

@SergioBertolinSG

Copy link
Copy Markdown
Contributor

Integration tests are starting to get too slow. Removing the code executed before and after scenarios when not needed will speed them.

@SergioBertolinSG

Copy link
Copy Markdown
Contributor Author

Problems with sharing.Creating link share with edit permissions keeps it
Capabilities and sharees.

@sharidas sharidas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. 👍

@SergioBertolinSG SergioBertolinSG merged commit de92767 into master Jun 12, 2017
@SergioBertolinSG SergioBertolinSG deleted the inttest-making-them-faster branch June 12, 2017 07:27
@SergioBertolinSG

Copy link
Copy Markdown
Contributor Author

Maybe backporting this we can fix the auth problem?

08:17:02 ┌─ @BeforeScenario # FeatureContext::prepareParameters()
08:17:02 │
08:17:02 ╳ Failed asserting that '' contains "testing".

@SergioBertolinSG

Copy link
Copy Markdown
Contributor Author

I'll prepare a PR.

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants