Skip to content

Add email option to user:add command#28122

Merged
PVince81 merged 1 commit into
masterfrom
occ-user-add-email
Jul 5, 2017
Merged

Add email option to user:add command#28122
PVince81 merged 1 commit into
masterfrom
occ-user-add-email

Conversation

@tomneedham

Copy link
Copy Markdown
Contributor

Description

In the user:add command you can now specify the email for a user.

I would consider this a regression in functionality, assigned 10.0.3 to reintroduce this feature.

Related Issue

https://central.owncloud.org/t/setting-email-with-occ-doesnt-show-in-gui/7987/3

Motivation and Context

Now that emails are stored in the accounts table there is no way to set the email of a user via occ. Since it is metadata stored alongside users in the accounts table I thought it made sense to add this to the user:add command.

How Has This Been Tested?

Local command line.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@PVince81

Copy link
Copy Markdown
Contributor

Fine by me 👍

@tomneedham was this removed on purpose ? Any link to the diff/PR that removed this option ?

Would like to hear from @DeepDiver1975 if it was on purpose.

@tomneedham

Copy link
Copy Markdown
Contributor Author

My guess was that since we used to have email in the preferences table, we never added this to the user add command after the accounts table was added. Unless I missed this getting removed...

@tomneedham

Copy link
Copy Markdown
Contributor Author

(You used to be able to run ./occ user:setting email --value=$email)

@tomneedham

Copy link
Copy Markdown
Contributor Author

jenkins died from mysql/docker issues....

@PVince81

Copy link
Copy Markdown
Contributor

@tomneedham rebase it to death until it works

@tomneedham

Copy link
Copy Markdown
Contributor Author

I'm going to script this at some point:

  • curl github PR api and get CI status
  • curl jenkins console | grep 'mysql timeout'
  • git rebase origin/master && git push -f origin $branch

-.-

@tomneedham tomneedham force-pushed the occ-user-add-email branch from 3a436a1 to 8bac38e Compare June 21, 2017 08:45
@PVince81

Copy link
Copy Markdown
Contributor

if you do, make sure to give the script a violent name like "kick-jenkins", "hit-jenkins-in-the-face" or so

@tomneedham tomneedham force-pushed the occ-user-add-email branch from 8bac38e to 1d44fac Compare June 27, 2017 13:51
@tomneedham

Copy link
Copy Markdown
Contributor Author

kicked

@PVince81 PVince81 force-pushed the occ-user-add-email branch from 1d44fac to 58ce452 Compare July 4, 2017 09:10
@PVince81

PVince81 commented Jul 4, 2017

Copy link
Copy Markdown
Contributor

rebased 🔨

@PVince81 PVince81 force-pushed the occ-user-add-email branch from 58ce452 to 0c79324 Compare July 5, 2017 10:34
@PVince81

PVince81 commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

rebased 🔨

@tomneedham can you raise the backport PR to stable10 ?

@PVince81 PVince81 merged commit 1611dad into master Jul 5, 2017
@PVince81 PVince81 deleted the occ-user-add-email branch July 5, 2017 15:27
@PVince81

PVince81 commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

stable10: #28306

@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants