UI tests default timeout constant and accurate timer calculations

[phil-davis]

Signed-off-by: Phil Davis phil@jankaritech.com

Description

1. Use a constant for the default timeout of functions that wait for something to complete in the browser.
2. Set this to 10 seconds (10000msec) - there was actually no good reason that some places used 5000msec and others 10000msec.
3. Implement code to more accurately calculate and compare the timeout end time against the current time in remaining places that should have it. (This was done already in some places by another PR)

Related Issue

#27858

Motivation and Context

1. Clean up repeated use of magic numbers 5000 and 10000.
2. Make timeouts on page-loading-type more accurately reflect the specified timeout.

How Has This Been Tested?

Manual run of the tests, and running in a separate repo with Travis/Saucelabs.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Refactoring

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[individual-it]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.