Fix new DAV quota check target path by PVince81 · Pull Request #28160 · owncloud/core

PVince81 · 2017-06-19T21:12:28Z

Description

Fixes the following:

use correct actual path in QuotaPlugin when coming from the new DAV endpoint
add quota check when moving FutureFile using chunked upload to new DAV endpoint

Also adds quota test hypercube to make sure we didn't forget anything, from owncloud/QA#461

Related Issue

Fixes #28159
Fixes owncloud/QA#461

Motivation and Context

One must not be able to bypass quotas

How Has This Been Tested?

Automated tests.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

TODO:

integration tests (test first!)
the actual fix

cc @SergioBertolinSG

PVince81 · 2017-06-20T07:12:23Z

@SergioBertolinSG it's too early for review but thanks for confirming the two cases I added.

PVince81 · 2017-06-22T16:34:25Z

I'm done, please review:

@SergioBertolinSG please review my test changes and additions.

@DeepDiver1975 please review the QuotaPlugin additions which are related to new dav. I know they're not ideal but I'm aiming for a backportable fix here. (we could use getNodeForPath for a cleaner fix)

PVince81 · 2017-06-23T08:43:20Z

I'll address the failing unit tests

PVince81 · 2017-06-23T10:08:06Z

@SergioBertolinSG I have now added overwrite upload test cases for everything to make sure all is covered.

Now QuotaPlugin was switched to always use getNodeForPath instead of using path trickery. The automated tests confirm that it still works.

@DeepDiver1975 @jvillafanez please review

PVince81 · 2017-06-23T12:16:04Z

Rebased to restart unstable CI env

SergioBertolinSG · 2017-06-23T12:56:53Z

👍 for the integration tests part.

PVince81 · 2017-06-23T18:34:37Z

rebased due to Jenkins' sudden death

PVince81 · 2017-06-26T07:32:55Z

Aha, finally a legit failure:

23:20:56     /var/lib/jenkins/workspace/owncloud-core_core_PR-28160-GE6VZMPMYVCIQXV7U5Z2R262UNHGEWXD3YK3XVDVFGZDMDFAFJXQ/tests/integration/features/checksums.feature:145

PVince81 · 2017-06-26T07:48:56Z

 		$source = '/uploads/' . $user . '/' . $id . '/.file';
 		$destination = substr($this->baseUrl, 0, -4) . $this->getDavFilesPath($user) . $dest;
-		$this->makeDavRequest($user, 'MOVE', $source, [
+		$this->response = $this->makeDavRequest($user, 'MOVE', $source, [


looks like storing the response here makes the checksum test fail, weird...

PVince81 · 2017-06-26T08:01:58Z

Fixed checksum test by making it check the HTTP status earlier.

jvillafanez · 2017-06-26T08:28:29Z

👍

PVince81 · 2017-06-26T08:40:00Z

@owncloud-bot I hate you

10:05:08 Fire up the mysql docker
10:05:09 Waiting for MySQL(utf8mb4) initialisation ...
10:06:05 ...........................
10:06:06 MySQL(utf8mb4)  is up.
10:06:06 Installing ....
10:06:06 ownCloud is not installed - only a limited number of commands are available
10:06:11 Error while trying to create admin user: Failed to connect to the database: An exception occured in driver: SQLSTATE[HY000] [1045] Access denied for user 'oc_autotest4'@'172.17.0.1' (using password: YES)
10:06:11  -> 
10:06:11 Kill the docker cc8c93196e8ade792a9dc1db92eb226b25bdfb0b17fa570f03be2a5d5df0f424
10:06:11 cc8c93196e8ade792a9dc1db92eb226b25bdfb0b17fa570f03be2a5d5df0f424
10:06:11 cc8c93196e8ade792a9dc1db92eb226b25bdfb0b17fa570f03be2a5d5df0f424
10:06:11 Makefile:179: recipe for target 'test-php' failed
10:06:11 make: *** [test-php] Error 1

- use correct actual path in `QuotaPlugin` when coming from the new DAV endpoint - add quota check when moving FutureFile using chunked upload to new DAV endpoint

Due to a small change in the Webdav test steps, the response of the last Webdav call is stored now, so we need to check the HTTP status earlier.

PVince81 · 2017-06-27T13:02:40Z

anotherrrrr rrrrebase

PVince81 · 2017-06-29T15:23:41Z

stable10: #28261

lock · 2019-08-03T06:01:36Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

PVince81 added the 2 - Developing label Jun 19, 2017

PVince81 added this to the 10.0.3 milestone Jun 19, 2017

PVince81 self-assigned this Jun 19, 2017

PVince81 mentioned this pull request Jun 19, 2017

Quota check for shared storage doesn't kick in for received shares in new DAV endpoint #28159

Closed

SergioBertolinSG self-requested a review June 20, 2017 06:53

SergioBertolinSG approved these changes Jun 20, 2017

View reviewed changes

PVince81 mentioned this pull request Jun 22, 2017

Automated tests for quota checks owncloud/QA#461

Closed

PVince81 force-pushed the fix-newdav-share-quota branch from e89af08 to 6f98716 Compare June 22, 2017 16:30

PVince81 added 3 - To Review sev1-critical and removed 2 - Developing labels Jun 22, 2017

PVince81 requested review from DeepDiver1975 and jvillafanez June 22, 2017 16:33

PVince81 force-pushed the fix-newdav-share-quota branch from 6f98716 to 36aeb0d Compare June 23, 2017 10:07

PVince81 force-pushed the fix-newdav-share-quota branch from 36aeb0d to 00d9078 Compare June 23, 2017 12:15

PVince81 mentioned this pull request Jun 23, 2017

Old chunking on new endpoint broken when using if-match header #28197

Closed

PVince81 force-pushed the fix-newdav-share-quota branch from 00d9078 to 5c15769 Compare June 23, 2017 18:34

PVince81 commented Jun 26, 2017

View reviewed changes

Add quota tests hypercube

9d0d7d6

Vincent Petry added 3 commits June 27, 2017 15:02

Fix quota checks for new endpoint

622e2d5

- use correct actual path in `QuotaPlugin` when coming from the new DAV endpoint - add quota check when moving FutureFile using chunked upload to new DAV endpoint

Use getNodeForPath in QuotaPlugin for more accurate path

f7748f4

Fix checksum test to check http status earlier

c6e1a85

Due to a small change in the Webdav test steps, the response of the last Webdav call is stored now, so we need to check the HTTP status earlier.

PVince81 force-pushed the fix-newdav-share-quota branch from 688da46 to c6e1a85 Compare June 27, 2017 13:02

PVince81 merged commit 2548f08 into master Jun 29, 2017

PVince81 deleted the fix-newdav-share-quota branch June 29, 2017 15:22

PVince81 mentioned this pull request Jun 29, 2017

[stable10] Fix newdav share quota check #28261

Merged

PVince81 mentioned this pull request Aug 7, 2017

ChunkingNG: Check free hd space before assembling file #28585

Closed

lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019

Uh oh!

Conversation

PVince81 commented Jun 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

TODO:

Uh oh!

PVince81 commented Jun 20, 2017

Uh oh!

PVince81 commented Jun 22, 2017

Uh oh!

PVince81 commented Jun 23, 2017

Uh oh!

PVince81 commented Jun 23, 2017

Uh oh!

PVince81 commented Jun 23, 2017

Uh oh!

SergioBertolinSG commented Jun 23, 2017

Uh oh!

PVince81 commented Jun 23, 2017

Uh oh!

PVince81 commented Jun 26, 2017

Uh oh!

PVince81 Jun 26, 2017

Choose a reason for hiding this comment

Uh oh!

PVince81 commented Jun 26, 2017

Uh oh!

jvillafanez commented Jun 26, 2017

Uh oh!

PVince81 commented Jun 26, 2017

Uh oh!

PVince81 commented Jun 27, 2017

Uh oh!

PVince81 commented Jun 29, 2017

Uh oh!

lock Bot commented Aug 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PVince81 commented Jun 19, 2017 •

edited

Loading