Skip to content

Markdown support for app descriptions ...#28191

Merged
DeepDiver1975 merged 2 commits into
masterfrom
markdown-support
Oct 23, 2017
Merged

Markdown support for app descriptions ...#28191
DeepDiver1975 merged 2 commits into
masterfrom
markdown-support

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Jun 22, 2017

Copy link
Copy Markdown
Member

Description

More and more apps use markdown in the description - we need to support this in the apps settings panel as well

Screenshots (if appropriate):

bildschirmfoto von 2017-06-22 11-16-05

vs

bildschirmfoto von 2017-06-22 11-18-20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.1 milestone Jun 22, 2017
@PVince81

Copy link
Copy Markdown
Contributor

any potential security implications, XSS or so ? @Peter-Prochaska

@peterprochaska

Copy link
Copy Markdown
Contributor

No

@ghost

ghost commented Jun 23, 2017

Copy link
Copy Markdown

Just to note that the * bulletpoints in the new screenshot for GpxPod are not rendered like e.g. on the marketplace page:

https://marketplace.owncloud.com/apps/gpxpod

@DeepDiver1975 DeepDiver1975 self-assigned this Oct 19, 2017
@DeepDiver1975 DeepDiver1975 modified the milestones: 10.1, development Oct 19, 2017
@codecov

codecov Bot commented Oct 20, 2017

Copy link
Copy Markdown

Codecov Report

Merging #28191 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #28191      +/-   ##
============================================
+ Coverage     59.59%   59.59%   +<.01%     
  Complexity    17170    17170              
============================================
  Files          1029     1029              
  Lines         57238    57239       +1     
============================================
+ Hits          34113    34114       +1     
  Misses        23125    23125
Impacted Files Coverage Δ Complexity Δ
settings/templates/panels/admin/apps.php 100% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 558e298...c2a7dce. Read the comment docs.

@lordelix lordelix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm … I don't like the visual look at all, but this is a topic for another day. ;-)

@DeepDiver1975

Copy link
Copy Markdown
Member Author

Hmm … I don't like the visual look at all, but this is a topic for another day. ;-)

Feel free to change this ;-)

@lordelix

lordelix commented Oct 23, 2017

Copy link
Copy Markdown
Contributor

Feel free to change this ;-)

That will be a bigger undertaking and should (will) happen in a bigger context.

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants