Skip to content

Add Win10 User Agent for FakeLockerPlugin. Add missing response status.#28204

Merged
tomneedham merged 1 commit into
masterfrom
unknown repository
Jun 28, 2017
Merged

Add Win10 User Agent for FakeLockerPlugin. Add missing response status.#28204
tomneedham merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jun 23, 2017

Copy link
Copy Markdown

Description

This User-Agent was already added in #23094 based on #22596 so adding it here as well. Also adding a 200 status code which was missing.

This might also fix the following report: https://central.owncloud.org/t/owncloud-webdav-doesnt-work-after-windows-creators-update/8183

I don't have a user account at central so it would be cool if some one with an account could ping the user there to test this change.

Related Issue

Fixes #28203

Motivation and Context

Introduce workaround for Windows 10 WebDAV.

Adding the 200 status code might also solve issues with Finder on Mac OS X.

How Has This Been Tested?

Not tested as i don't have a Windows or Mac OS X system.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghost

ghost commented Jun 24, 2017

Copy link
Copy Markdown
Author

The missing status code can be easily tested via a curl request like:

curl -X LOCK -A "WebDAVFS" -u "test:test" "https://demo.owncloud.org/remote.php/dav/files/test/ownCloud%20Manual.pdf"

which currently returns an internal server error with the following reply:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception</s:exception>
  <s:message>No subsystem set a valid HTTP status code. Something must have interrupted the request without providing further detail.</s:message>
</d:error>

@hlecorche

Copy link
Copy Markdown

@kdslkdsaldsal It's works. Thanks

<?xml version="1.0"?>
<d:prop xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:cal="urn:ietf:para                                                                     ms:xml:ns:caldav" xmlns:cs="http://calendarserver.org/ns/" xmlns:card="urn:ietf:                                                                     params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
 <d:lockdiscovery>
  <d:activelock>
   <d:lockscope>
    <d:exclusive/>
   </d:lockscope>
   <d:locktype>
    <d:write/>
   </d:locktype>
   <d:lockroot>
    <d:href>files/test/ownCloud Manual.pdf</d:href>
   </d:lockroot>
   <d:depth>infinity</d:depth>
   <d:timeout>Second-1800</d:timeout>
   <d:locktoken>
    <d:href>opaquelocktoken:dd11a402402caa9034b4dda88a068e55</d:href>
   </d:locktoken>
   <d:owner/>
  </d:activelock>
 </d:lockdiscovery>
</d:prop>

@ghost

ghost commented Jun 24, 2017

Copy link
Copy Markdown
Author

Thanks for testing 👍

Failed test seems unrelated to me:

10:12:27 Installing ....
10:12:27 ownCloud is not installed - only a limited number of commands are available
10:12:27 Oracle connection could not be established
10:12:27  -> ORA-01033: ORACLE initialization or shutdown in progress Check environment: ORACLE_HOME=/usr/lib/oracle/12.1/client64 ORACLE_SID= LD_LIBRARY_PATH= NLS_LANG= tnsnames.ora is not readable
10:12:27 Kill the docker 11a6aa7631aaf32d4ebfacda9cd71121f289341416e012327b78ea93689c5f04

@ghost ghost changed the title Fix Windows10 WebDAV by adding the FakeLockerPlugin. Add missing response status. Add Win10 User Agent for FakeLockerPlugin. Add missing response status. Jun 24, 2017
@DeepDiver1975 DeepDiver1975 added this to the 10.1 milestone Jun 25, 2017
@DeepDiver1975 DeepDiver1975 self-requested a review June 25, 2017 19:17
@guruz

guruz commented Jul 3, 2017

Copy link
Copy Markdown
Contributor

\o/

@ghost

ghost commented Jul 3, 2017

Copy link
Copy Markdown
Author

stable9.1: #28288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when upload file with Windows 10 webdav client and simfs partition

5 participants