Add Win10 User Agent for FakeLockerPlugin. Add missing response status.#28204
Merged
Conversation
Author
|
The missing status code can be easily tested via a curl request like:
which currently returns an internal server error with the following reply: |
|
@kdslkdsaldsal It's works. Thanks |
Author
|
Thanks for testing 👍 Failed test seems unrelated to me: |
DeepDiver1975
approved these changes
Jun 25, 2017
Contributor
|
\o/ |
Author
|
stable9.1: #28288 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This User-Agent was already added in #23094 based on #22596 so adding it here as well. Also adding a 200 status code which was missing.
This might also fix the following report: https://central.owncloud.org/t/owncloud-webdav-doesnt-work-after-windows-creators-update/8183
I don't have a user account at central so it would be cool if some one with an account could ping the user there to test this change.
Related Issue
Fixes #28203
Motivation and Context
Introduce workaround for Windows 10 WebDAV.
Adding the 200 status code might also solve issues with Finder on Mac OS X.
How Has This Been Tested?
Not tested as i don't have a Windows or Mac OS X system.
Screenshots (if appropriate):
Types of changes
Checklist: