use efficient startsWith implementation, don't check if key exists twice#28213
Merged
Conversation
butonic
force-pushed
the
improve-query-performance
branch
from
c6a5c30 to
3a057be
Compare
PVince81
approved these changes
Jun 29, 2017
PVince81
left a comment
PVince81
left a comment
Contributor
There was a problem hiding this comment.
👍 since all tests still pass
Contributor
|
@butonic backport? |
Contributor
|
@butonic missing backport. If not required, please remove label |
Member
|
backport pr open |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #28212 I was profiling the performance for user:sync and this actually made a measurable difference.