Skip to content

Use "sharing" scope when sending notification#28226

Merged
PVince81 merged 1 commit into
masterfrom
share-notif-use-sharing-scope
Jun 27, 2017
Merged

Use "sharing" scope when sending notification#28226
PVince81 merged 1 commit into
masterfrom
share-notif-use-sharing-scope

Conversation

@PVince81

@PVince81 PVince81 commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

Description

Wire up old share api with group manager sharing scope. Required to make customgroup work with "notify user" checkbox.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jvillafanez please review

@PVince81 PVince81 added this to the 10.1 milestone Jun 27, 2017
@tomneedham

tomneedham commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

Restarted travis job which died randomly

@jvillafanez

Copy link
Copy Markdown
Member

Makes sense 👍

@PVince81 PVince81 merged commit 72cc00d into master Jun 27, 2017
@PVince81 PVince81 deleted the share-notif-use-sharing-scope branch June 27, 2017 16:14
@PVince81

Copy link
Copy Markdown
Contributor Author

stable10: #28237

@DeepDiver1975 DeepDiver1975 modified the milestones: 10.1, development Oct 10, 2017
@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants