Handle inconsistent filecache reads #28273
Merged
Merged
Conversation
tomneedham
changed the title
Contributor
|
Also fixed by #28166 |
PVince81
approved these changes
Jul 3, 2017
PVince81
left a comment
PVince81
left a comment
Contributor
There was a problem hiding this comment.
👍 assuming you did some regression testing with desktop client
Contributor
|
@tomneedham backport ? what version was affected ? |
Contributor
|
@tomneedham please backport down to stable9, likely related to filecache corruption |
Contributor
|
@tomneedham missing backport |
Contributor
|
stable10: #28710 |
Contributor
|
backport further ? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have some reports of many undefined indexes in the owncloud logs generated when
->get()is called with a fileid, but there is no database row. This PR fixes the cache logic to catch these cases properly and return a correctfalseresponse.Should be backported to 10 and 9.1 as well.
How Has This Been Tested?
Running the unit tests.
Types of changes
Checklist: