Use V4 signature with london s3 region#28283
Merged
Merged
Conversation
PVince81
approved these changes
Jul 3, 2017
PVince81
left a comment
PVince81
left a comment
Contributor
There was a problem hiding this comment.
👍 please also test a non-london location
Contributor
|
the jenkins needs the boot |
Contributor
|
rebased ⛏ |
PVince81
force-pushed
the
s3-london-region
branch
from
f85c300 to
15c5159
Compare
Contributor
Author
|
This is a hotfix, and the more I see issues around this I think we should look at fixing it properly. I think we may also have a signature issue with the frankfurt region. |
PVince81
force-pushed
the
s3-london-region
branch
from
15c5159 to
c921e2e
Compare
Contributor
|
Rebased 🔨 @tomneedham or do you want to abandon this hotfix and go for a cleaner fix ? I think I'd rather have this in first |
This was referenced Jul 10, 2017
Contributor
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forces the use of V4 style AWS signature when using the london region.
Also, consider updating of the AWS library in core: #28282
Motivation and Context
How Has This Been Tested?
Tested creating a london s3 external mount
Screenshots (if appropriate):
Types of changes
Checklist: