Handle read only apps folders properly by DeepDiver1975 · Pull Request #28543 · owncloud/core

DeepDiver1975 · 2017-07-31T14:09:07Z

Description

This is planned to support clustered setup much better ....

Related Issue

refs https://github.com/owncloud/platform/issues/133

How Has This Been Tested?

add the config parameter 'cluster.mode' -> true
try to install
try to operate as usual
expectation: nothing will break apart ....

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

PVince81

Please add back the check for "config_is_read_only" as upgrading to 10.0.3 would likely cause surprises for people who have it set.

If we want to remove it then deprecate it in 10.0.3 and remove completely in 11.0. But I'm not sure if we should remove it as some people without cluster setup might want to have the config read-only, so they wouldn't think about setting cluster mode.

PVince81 · 2017-08-01T07:52:13Z

 	}
+
+	public function isReadOnly() {
+		if (!$this->getValue('installed', false)) {


also include the config_is_read_only key here ?

PVince81 · 2017-08-01T07:53:53Z

 		$appId = OC_App::cleanAppId($info['id']);
-		$basedir = OC_App::getInstallPath().'/'.$appId;
+		$appsFolder = OC_App::getInstallPath();
+		if ($appsFolder === null) {


looks like you should also add is_writeable and is_readable here ? See https://github.com/owncloud/core/pull/28543/files#diff-ec8c121d705ff47eacbfdd23f36a9f6cL731.

PVince81 · 2017-08-01T07:54:36Z

-					<option value='<?php p($secure)?>' <?php p($selected) ?>><?php p($name) ?></option>
-				<?php endforeach;?>
-			</select>
+			<?php p($l->t('The config file is read only. Please adopt your setup by editing the config file manually.')); ?>


adopting a child ?

=> adjust

PVince81 · 2017-08-01T07:55:18Z

-			</select>
+			<?php p($l->t('The config file is read only. Please adopt your setup by editing the config file manually.')); ?>
+			<br>
+			<?php p($l->t('In a clustered setup please make sure to sync the file across all nodes.')); ?>


s/the file/the config.php file/

to make sure this is clear

DeepDiver1975 · 2017-08-01T14:41:55Z

@PVince81 thanks for your feedback - I removed the config parameter 'cluster.mode' now totally. 'config_is_read_only' will do its job for now

PVince81 · 2017-08-01T14:43:58Z

hmm, so does it mean that "config_read_only" will now also block the apps folder ? People who had this set will be surprised that they can't install new apps ?

DeepDiver1975 · 2017-08-01T14:52:34Z

hmm, so does it mean that "config_read_only" will now also block the apps folder ? People who had this set will be surprised that they can't install new apps ?

Thats my point about this all: it's a mess and needs cleanup .... this was the idea in having ONE config switch to rule them all ... 😉

PVince81 · 2017-08-03T13:38:54Z

@DeepDiver1975 do we want to surprise these people ? If yes, will need proper communication

DeepDiver1975 · 2017-08-03T13:43:42Z

@DeepDiver1975 do we want to surprise these people ? If yes, will need proper communication

so you advocate for keeping two intendant checks

config_is_read_only for config stuff only
and test if apps folder is writable

PVince81 · 2017-08-03T13:59:51Z

If this was OC 11 I'd be fine with breaking the way it works.

For OC 10 the easiest is just do nothing and maybe add a note about clustering in the documentation about the two settings to change:

config_is_read_only
the "apps_paths" setting with "writable" set to false

Now if the above doesn't work correctly then we should fix that at least.

DeepDiver1975 · 2017-08-03T14:56:36Z

@PVince81 a much simpler solution now - only addressing if the apps folder is writable

PVince81

👍 that's better, thanks.

Please rename issue title and merge if you tested this and all still worked fine

…loud/platform#133

lock · 2019-08-02T23:01:58Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

DeepDiver1975 added the 3 - To Review label Jul 31, 2017

DeepDiver1975 added this to the development milestone Jul 31, 2017

DeepDiver1975 requested a review from PVince81 July 31, 2017 14:09

felixboehm added the p1-urgent Critical issue, need to consider hotfix with just that issue label Jul 31, 2017

PVince81 reviewed Aug 1, 2017

View reviewed changes

DeepDiver1975 mentioned this pull request Aug 1, 2017

Handle cluster setup owncloud/market#125

Merged

DeepDiver1975 added the backport-request label Aug 1, 2017

DeepDiver1975 force-pushed the handle-cluster-setup branch from 2490eec to 7eb5dba Compare August 1, 2017 14:39

DeepDiver1975 force-pushed the handle-cluster-setup branch from 7eb5dba to 1155cc4 Compare August 3, 2017 13:59

DeepDiver1975 force-pushed the handle-cluster-setup branch 2 times, most recently from 30f9b82 to d93b2c9 Compare August 3, 2017 14:55

PVince81 approved these changes Aug 3, 2017

View reviewed changes

DeepDiver1975 changed the title ~~Introduce cluster.mode~~ Handle read only apps folders properly Aug 3, 2017

Adjust behaviour in case the apps folder is not writable - refs ownc…

fa75a5a

…loud/platform#133

DeepDiver1975 force-pushed the handle-cluster-setup branch from d93b2c9 to fa75a5a Compare August 3, 2017 15:15

PVince81 assigned DeepDiver1975 Aug 7, 2017

PVince81 added 4 - To release and removed 3 - To Review labels Aug 7, 2017

DeepDiver1975 merged commit 8d0bdd6 into master Aug 7, 2017

DeepDiver1975 deleted the handle-cluster-setup branch August 7, 2017 11:00

DeepDiver1975 mentioned this pull request Aug 7, 2017

[stable10] Adjust behaviour in case the apps folder is not writable … #28601

Merged

DeepDiver1975 removed the backport-request label Nov 3, 2017

ownclouders added the status/STALE label Dec 20, 2017

lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019

Uh oh!

Conversation

DeepDiver1975 commented Jul 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

PVince81 left a comment

Choose a reason for hiding this comment

Uh oh!

PVince81 Aug 1, 2017

Choose a reason for hiding this comment

Uh oh!

PVince81 Aug 1, 2017

Choose a reason for hiding this comment

Uh oh!

PVince81 Aug 1, 2017

Choose a reason for hiding this comment

Uh oh!

PVince81 Aug 1, 2017

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 commented Aug 1, 2017

Uh oh!

PVince81 commented Aug 1, 2017

Uh oh!

DeepDiver1975 commented Aug 1, 2017

Uh oh!

PVince81 commented Aug 3, 2017

Uh oh!

DeepDiver1975 commented Aug 3, 2017

Uh oh!

PVince81 commented Aug 3, 2017

Uh oh!

DeepDiver1975 commented Aug 3, 2017

Uh oh!

PVince81 left a comment

Choose a reason for hiding this comment

Uh oh!

lock Bot commented Aug 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DeepDiver1975 commented Jul 31, 2017 •

edited

Loading