Skip to content

send 403 error when preview is blocked by firewall rule#28559

Merged
individual-it merged 1 commit into
masterfrom
correct-error-blocked-preview
Aug 2, 2017
Merged

send 403 error when preview is blocked by firewall rule#28559
individual-it merged 1 commit into
masterfrom
correct-error-blocked-preview

Conversation

@individual-it

Copy link
Copy Markdown
Member

Description

setting correct error code when file preview of public links is blocked

Related Issue

https://github.com/owncloud/firewall/issues/366

Motivation and Context

server does return the wrong error code when previews of files are blocked

How Has This Been Tested?

manually & by writing tests for the firewall app

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@individual-it

Copy link
Copy Markdown
Member Author

backport to stable10 in #28565

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants