Save and restore skeleton dir for integration and UI tests#28603
Merged
Conversation
Member
|
backport to stable10? |
Contributor
Author
|
Backport in #28610 |
Member
|
we could not get rid of the line "skeletondirectory set to /tests/ui/skeleton." in https://github.com/owncloud/documentation/blob/master/developer_manual/core/ui-testing.rst or not? |
phil-davis
added a commit
to owncloud-archive/documentation
that referenced
this pull request
Aug 10, 2017
Now it happens automatically in the script that runs the tests: owncloud/core#28603
Contributor
Author
|
Doc update in owncloud-archive/documentation#3288 |
10 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When starting integration or UI tests, remember the previous value of skeletondirectory
At the end, out it back
Remove the now-unneeded setting of skeletondirectory in preseed-config.php
Related Issue
#28602
Motivation and Context
Make life easier for development manual runs of integration and UI tests
How Has This Been Tested?
Repeat with skeletondirectory undefined, make sure it stays undefined after each test run.
Types of changes
Checklist: