Skip to content

Save and restore skeleton dir for integration and UI tests#28603

Merged
phil-davis merged 1 commit into
masterfrom
integration-and-ui-test-state
Aug 8, 2017
Merged

Save and restore skeleton dir for integration and UI tests#28603
phil-davis merged 1 commit into
masterfrom
integration-and-ui-test-state

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

When starting integration or UI tests, remember the previous value of skeletondirectory
At the end, out it back
Remove the now-unneeded setting of skeletondirectory in preseed-config.php

Related Issue

#28602

Motivation and Context

Make life easier for development manual runs of integration and UI tests

How Has This Been Tested?

  1. Set skeletondirectory to some "random" string
  2. Run some UI tests - make sure they work
  3. Check that skeletondirectory keeps its value
  4. Run some integration tests - make sure they work
  5. Check that skeletondirectory keeps its value

Repeat with skeletondirectory undefined, make sure it stays undefined after each test run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@individual-it individual-it left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and usefull

@individual-it

Copy link
Copy Markdown
Member

backport to stable10?

@phil-davis phil-davis merged commit ba62ff6 into master Aug 8, 2017
@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport in #28610

@phil-davis phil-davis deleted the integration-and-ui-test-state branch August 8, 2017 03:26
@individual-it

Copy link
Copy Markdown
Member

we could not get rid of the line "skeletondirectory set to /tests/ui/skeleton." in https://github.com/owncloud/documentation/blob/master/developer_manual/core/ui-testing.rst or not?

phil-davis added a commit to owncloud-archive/documentation that referenced this pull request Aug 10, 2017
Now it happens automatically in the script that runs the tests:
owncloud/core#28603
@phil-davis

Copy link
Copy Markdown
Contributor Author

Doc update in owncloud-archive/documentation#3288

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants