Skip to content

Make lost password errors distinguishable#28624

Merged
DeepDiver1975 merged 2 commits into
masterfrom
distinguish-lost-password-errors
Aug 18, 2017
Merged

Make lost password errors distinguishable#28624
DeepDiver1975 merged 2 commits into
masterfrom
distinguish-lost-password-errors

Conversation

@butonic

@butonic butonic commented Aug 9, 2017

Copy link
Copy Markdown
Contributor
  1. Make the error messages distinguishable. Allows actually debugging the problem. Using cryptic numbers would not increase security because an attacker can just look them up in the code.
  2. In written form Couldn't becomes Could not

@butonic butonic force-pushed the distinguish-lost-password-errors branch from 1b56adc to 7f872a5 Compare August 9, 2017 08:15
@butonic butonic force-pushed the distinguish-lost-password-errors branch from 7f872a5 to eb8a782 Compare August 9, 2017 08:50
@butonic butonic added this to the development milestone Aug 9, 2017
@butonic butonic self-assigned this Aug 9, 2017
@DeepDiver1975

Copy link
Copy Markdown
Member

do these messages hit the user in the ui? needs proper analysis by @Peter-Prochaska

@dercorn dercorn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 👍

@PVince81

Copy link
Copy Markdown
Contributor

@DeepDiver1975 merge or delay ? All I see is "n't" replaced with "not" and I don't see how it would be wrong to change this

@butonic

butonic commented Aug 18, 2017

Copy link
Copy Markdown
Contributor Author

The exception messages now end differently.

@DeepDiver1975 DeepDiver1975 merged commit 337e978 into master Aug 18, 2017
@DeepDiver1975 DeepDiver1975 deleted the distinguish-lost-password-errors branch August 18, 2017 19:01
@DeepDiver1975

Copy link
Copy Markdown
Member

@butonic backport?

@butonic

butonic commented Aug 18, 2017

Copy link
Copy Markdown
Contributor Author

yes, makes supporting 10.0.3 a little easier

@DeepDiver1975

Copy link
Copy Markdown
Member

pr open ....

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants