[stable10] Switch web UI to new dav + encoding fixes#28769
Merged
Conversation
Encode with encodeURIComponent again. Note that "@" gets encoded to "%40" but when Sabre DAV returns a PROPFIND response, the "@" in the URL is not encoded. To make sure that the href root is properly match, we now compare each section individually in their decoded form.
The client takes care of encoding them when doing the Webdav requests
This was referenced Aug 22, 2017
Contributor
Author
|
@davitol mind retesting ? The code is slightly different here |
Contributor
|
Tested and works 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25494 and #28749 to stable10.
Retested with a user "test@test" and file operations like creating dir, upload and chunk upload work fine.