Improve market upgrade messages + new switch#28812
Merged
Merged
Conversation
Improve market upgrade messages. Added switch to disable automatic app updates during occ upgrade.
Even if no internet connection is available, we still need to verify that there are no incompatible apps on upgrade and show an appropriate message.
Contributor
Author
jvillafanez
reviewed
Aug 31, 2017
| $link = $this->defaults->buildDocLinkToKey('admin-marketplace-apps'); | ||
| $output->info('No internet connection available - no app updates will be taken from the marketplace.'); | ||
| $output->info("How to update apps in such situation please see $link"); | ||
| return; |
Member
There was a problem hiding this comment.
This will likely change the behaviour. Is it fine?
Contributor
Author
There was a problem hiding this comment.
Yes, this is intended. We should not return directly because even if we don't attempt contacting the marketplace, we should still check if there is any incompatible app or app missing code blocking the update. Returning here would bypass the check and result in a broken OC in such scenarios.
jvillafanez
approved these changes
Aug 31, 2017
jvillafanez
left a comment
jvillafanez
left a comment
Member
There was a problem hiding this comment.
Code looks fine, not tested.
Contributor
Author
|
stable10: #28871 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve market upgrade messages.
Added switch to disable automatic app updates during occ upgrade.
Related Issue
Fixes #28734
Motivation and Context
How Has This Been Tested?
upgrade.automatic-app-updateis set to falseupgrade.automatic-app-updateis set to falseScreenshots (if appropriate):
Types of changes
Checklist: