Skip to content

add share_with index#28847

Merged
PVince81 merged 1 commit into
masterfrom
add-share_with-index
Aug 30, 2017
Merged

add share_with index#28847
PVince81 merged 1 commit into
masterfrom
add-share_with-index

Conversation

@butonic

@butonic butonic commented Aug 30, 2017

Copy link
Copy Markdown
Contributor

screen shot 2017-08-30 at aug 30 2017 10 56am

screen shot 2017-08-30 at aug 30 2017 10 57am

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to name the class Version20170830112305
image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy pasta error ...

@butonic butonic force-pushed the add-share_with-index branch from 741f5e4 to d492b16 Compare August 30, 2017 10:15
@butonic butonic force-pushed the add-share_with-index branch from d492b16 to 5e9c516 Compare August 30, 2017 10:57

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

Copy link
Copy Markdown
Contributor

@butonic please backport to stable10

@PVince81 PVince81 added this to the development milestone Aug 30, 2017
@PVince81 PVince81 merged commit ea19298 into master Aug 30, 2017
@PVince81 PVince81 deleted the add-share_with-index branch August 30, 2017 14:25
@PVince81

Copy link
Copy Markdown
Contributor

@butonic @tomneedham please backport

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants