Skip to content

[WIP] Don't watch storage parents of current request#28855

Closed
PVince81 wants to merge 1 commit into
masterfrom
watcher-exclusion
Closed

[WIP] Don't watch storage parents of current request#28855
PVince81 wants to merge 1 commit into
masterfrom
watcher-exclusion

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

Description

Prevents trying to detect changes in parents of the current Webdav
request. This prevents update detection during critical operations like
deletion.

Related Issue

Fixes #28779

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Prevents trying to detect changes in parents of the current Webdav
request. This prevents update detection during critical operations like
deletion.
@PVince81 PVince81 added this to the development milestone Aug 30, 2017
@PVince81 PVince81 self-assigned this Aug 30, 2017
@PVince81

Copy link
Copy Markdown
Contributor Author

note: doesn't work... also, there might be an infinite loop... need more time

@PVince81

Copy link
Copy Markdown
Contributor Author

this PR is an alternative to #28853 with focus on solving #28779, but doesn't have the benefit of reducing filecache queries

@PVince81 PVince81 mentioned this pull request Aug 31, 2017
9 tasks
@PVince81

PVince81 commented Sep 4, 2017

Copy link
Copy Markdown
Contributor Author

Let's use #28853 instead

@PVince81 PVince81 closed this Sep 4, 2017
@PVince81 PVince81 deleted the watcher-exclusion branch September 4, 2017 08:07
@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deletion of several folders or files fails when using external storages.

2 participants