Skip to content

Remove AvatarPermissions repair step#28975

Merged
PVince81 merged 1 commit into
masterfrom
skip-avatar-repair
Oct 10, 2017
Merged

Remove AvatarPermissions repair step#28975
PVince81 merged 1 commit into
masterfrom
skip-avatar-repair

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

Description

It is obsoleted because avatars were moved to a separate folder during
upgrade.

Related Issue

#28902

Motivation and Context

Makes upgrade faster by not running extra queries.

How Has This Been Tested?

Increase version.php and rerun upgrade: no errors.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

It is obsoleted because avatars were moved to a separate folder during
upgrade.
@tomneedham

Copy link
Copy Markdown
Contributor

jenkins mysql docker timeout 😒

@jvillafanez

Copy link
Copy Markdown
Member

Code is fine, but we need to check the tests 👍

@PVince81 PVince81 modified the milestones: 10.0.3, development Sep 18, 2017
@PVince81

Copy link
Copy Markdown
Contributor Author

tests passed, merging

@PVince81 PVince81 merged commit 83b0cb8 into master Oct 10, 2017
@PVince81 PVince81 deleted the skip-avatar-repair branch October 10, 2017 15:36
@PVince81

Copy link
Copy Markdown
Contributor Author

stable10: #29202

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants