Skip to content

Add missing files_sharing capabilities#28977

Merged
PVince81 merged 1 commit into
masterfrom
missing-capabilities
Sep 18, 2017
Merged

Add missing files_sharing capabilities#28977
PVince81 merged 1 commit into
masterfrom
missing-capabilities

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

Add capabilities that are checkboxes on the admin settings sharing panel but are not currently published in the capabilities.

Related Issue

Motivation and Context

I was looking at integration tests and wondered why these were not tested, and how to (easily) find their current values.

How Has This Been Tested?

Looking at the response from the /cloud/capabilities endpoint.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis phil-davis added this to the development milestone Sep 11, 2017
@phil-davis phil-davis self-assigned this Sep 11, 2017
@phil-davis

phil-davis commented Sep 11, 2017

Copy link
Copy Markdown
Contributor Author

@PVince81 @DeepDiver1975 is there some reason that these are not published capabilities?

I have done a quick change here to illustrate the point. The exact names of the published capabilities and corresponding tests are needed...
Edit: unit and integration tests are done now.

@PVince81

Copy link
Copy Markdown
Contributor

The reason is likely that they were never used by clients before. It's only recently that we've been thinking of adding such config settings to the capabilities. We usually do it on-demand.

@PVince81 PVince81 modified the milestones: planned, development Sep 11, 2017
@phil-davis

phil-davis commented Sep 11, 2017

Copy link
Copy Markdown
Contributor Author

@PVince81 @DeepDiver1975 these are the 4 "missing" sharing checkbox settings from the settings-admin-sharing panel. It will be handy for future UI tests or other tests (or even clients!) to be able to easily query the settings of all these sort of capabilities.

If you like this, then the main thing is that the 4 new capabilities keys here are names that we think are good and will survive the test of time - because once some client/s make us of them, it is not easy to change them.

There is also shareapi_exclude_groups but that has a text field shareapi_exclude_groups_list

Should I publish the shareapi_exclude_groups capability (if it is on/off)?
And if so, do we also publish the text of shareapi_exclude_groups_list?

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 71b9b0e into master Sep 18, 2017
@PVince81 PVince81 deleted the missing-capabilities branch September 18, 2017 08:34
@PVince81

Copy link
Copy Markdown
Contributor

@michaelstingl likely interesting for clients ^

@phil-davis please backport

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport stable10 #29040

phil-davis added a commit to owncloud-archive/documentation that referenced this pull request Sep 18, 2017
the new example includes the new capabilities fields added by owncloud/core#28977
they should become available in 10.0.4 - so wait until then to publish this.
@phil-davis

Copy link
Copy Markdown
Contributor Author

Documentation update in owncloud-archive/documentation#3395

@michaelstingl

Copy link
Copy Markdown

@SamuAlfageme @nasli @davigonz @jesmrec FYI ^

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants