Fix doc blocks / namespacing - everywhere#28986
Merged
Merged
Conversation
Contributor
|
|
DeepDiver1975
requested changes
Sep 12, 2017
| * @return bool | ||
| * @throws BadRequest | ||
| * @throws ServiceUnavailable | ||
| * @throws \Sabre\DAV\Exception\Forbidden |
Contributor
There was a problem hiding this comment.
Not a duplicate: OCA\DAV\Connector\Sabre\Exception\Forbidden != \Sabre\DAV\Exception\Forbidden
Member
There was a problem hiding this comment.
then let's add a proper use statement
use \Sabre\DAV\Exception\Forbidden as SabreForbidden
butonic
approved these changes
Sep 13, 2017
tomneedham
force-pushed
the
doc-blocks
branch
from
5e2a6bc to
d4ac335
Compare
Contributor
Author
|
Fixed and prefixed sabre exceptions with 'Sabre' |
tomneedham
force-pushed
the
doc-blocks
branch
from
d4ac335 to
82f4052
Compare
Contributor
Author
|
horracle timeout |
tomneedham
force-pushed
the
doc-blocks
branch
from
82f4052 to
c9c67be
Compare
Contributor
Author
|
rebased for luck |
DeepDiver1975
approved these changes
Oct 10, 2017
tomneedham
force-pushed
the
doc-blocks
branch
from
c9c67be to
0964993
Compare
Contributor
Author
|
rebased - waiting for CI |
Contributor
Author
|
jenkins timeout - rebasing |
tomneedham
force-pushed
the
doc-blocks
branch
from
0964993 to
b2ea4f2
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(+ one bonus that was never actually included)