Skip to content

[WIP] Update guzzle and add integration test capabilities settings#29054

Closed
phil-davis wants to merge 5 commits into
masterfrom
update-guzzle-int-test-capabilties-settings
Closed

[WIP] Update guzzle and add integration test capabilities settings#29054
phil-davis wants to merge 5 commits into
masterfrom
update-guzzle-int-test-capabilties-settings

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

About to try integrating the Guzzle update with some integration test refactoring.
First pass - the Guzzle change and see if they pass CI OK.

@phil-davis phil-davis force-pushed the update-guzzle-int-test-capabilties-settings branch from c82bd78 to 98a362b Compare September 21, 2017 14:09
@individual-it

Copy link
Copy Markdown
Member

duplication of #28063

@phil-davis

Copy link
Copy Markdown
Contributor Author

Yes, last week I noticed that there was work to move to Guzzle v6 that changed quite a lot of integration test files. So I quickly did a merge of my proposed integration test refactoring changes on top of it - to see if there would be a lot of annoying conflicts. Actually it was quite easy to resolve the conflicts and Jenkins comes up with the same set of test fails as are currently happening in #28063

So my proposed refactorings in #28970 will not cause too much pain (and do not break anything for #28063 )

@PVince81

Copy link
Copy Markdown
Contributor

@phil-davis feel free to push directly to #28063 if your changes help solving / simplifying the Guzzle update

@PVince81

Copy link
Copy Markdown
Contributor

most of the guzzle related changes are on the tests anyway. The core changes are rather small.

@phil-davis

Copy link
Copy Markdown
Contributor Author

@PVince81 I will look in the morning. After the merge of my integration test stuff today, that WIP PR of yours will have conflicts to be resolved, but they are not difficult. Then there were a list of failed integration test scenarios. From memory, the fails in Jenkins here were the same as in your other PR:

490 scenarios (355 passed, 135 failed)
4522 steps (3772 passed, 135 failed, 615 skipped)

so there i a bit of guzzling to be done to tweak it into success.

@phil-davis

Copy link
Copy Markdown
Contributor Author

See #29211 for "the final solution"

@phil-davis phil-davis closed this Oct 19, 2017
@phil-davis phil-davis deleted the update-guzzle-int-test-capabilties-settings branch October 19, 2017 10:52
@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants