Skip to content

Make sure the folder name is editable (if required) after reloading or going back from oAuth2 flow#29147

Merged
PVince81 merged 1 commit into
masterfrom
force_inputs_enabled
Oct 16, 2017
Merged

Make sure the folder name is editable (if required) after reloading or going back from oAuth2 flow#29147
PVince81 merged 1 commit into
masterfrom
force_inputs_enabled

Conversation

@jvillafanez

Copy link
Copy Markdown
Member

Description

Try to keep the same page state when we go out and come back from other site via back button (such as during oAuth2 flow) or when we reload the page

Related Issue

#28480

Motivation and Context

folder names might not be editable as described and shown in the issue

How Has This Been Tested?

Manually tested in the personal page, storage section: 3 admin mounts plus 1 additional personal mount.

  • Reloading works, although the folder name of the new mount point might be prefilled, but it can be edited, which wasn't possible before
  • Clicking in the "grant access" button from any oAuth2 storage and going back with the browser has the same behaviour as the point above.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

going back to the ownCloud's page from another site (such as oAuth2)
@jvillafanez

Copy link
Copy Markdown
Member Author

Travis failures seem unrelated.

@phil-davis

Copy link
Copy Markdown
Contributor

Travis failures seem unrelated.
Indeed they were - I restarted the offending job and it passes. (sad that there are annoying intermittent timing issues driving UI tests)

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 36a292f into master Oct 16, 2017
@PVince81 PVince81 deleted the force_inputs_enabled branch October 16, 2017 08:09
@PVince81

Copy link
Copy Markdown
Contributor

@jvillafanez please backport to stable10

@jvillafanez

Copy link
Copy Markdown
Member Author

Backport to stable10: #29253

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants