Use path hash in selects from filecache to speed things up#29192
Merged
Conversation
PVince81
approved these changes
Oct 10, 2017
PVince81
left a comment
Contributor
There was a problem hiding this comment.
👍 as discussed, hope CI passes
Contributor
|
@tomneedham please backport all the way down and cherry-pick on the unmerged backport PRs |
Contributor
|
Contributor
|
@tomneedham did you add this on top of your backport PRs for stable9.1, stable9 ? |
Contributor
|
Currently missing on stable9 and stable9.1. Considering that stable9 is EOL and stable9.1 will be EOL in February, it might not be worth it. People should upgrade to 10 anyway. Removing backport label. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the repair step we do some queries on the file cache - and we should use the path_hash column as this has an index and will be much faster than doing a full table scan :)
Related Issue
Slow repair step progress reported in the wild 🌵
Types of changes
Checklist: