Skip to content

Use path hash in selects from filecache to speed things up#29192

Merged
PVince81 merged 1 commit into
masterfrom
repair-step-use-path-hash
Oct 10, 2017
Merged

Use path hash in selects from filecache to speed things up#29192
PVince81 merged 1 commit into
masterfrom
repair-step-use-path-hash

Conversation

@tomneedham

Copy link
Copy Markdown
Contributor

Description

During the repair step we do some queries on the file cache - and we should use the path_hash column as this has an index and will be much faster than doing a full table scan :)

Related Issue

Slow repair step progress reported in the wild 🌵

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tomneedham tomneedham added this to the development milestone Oct 10, 2017
@tomneedham tomneedham self-assigned this Oct 10, 2017
@tomneedham tomneedham requested a review from PVince81 October 10, 2017 08:59

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as discussed, hope CI passes

@PVince81 PVince81 merged commit d0afb2e into master Oct 10, 2017
@PVince81 PVince81 deleted the repair-step-use-path-hash branch October 10, 2017 15:39
@PVince81

Copy link
Copy Markdown
Contributor

@tomneedham please backport all the way down and cherry-pick on the unmerged backport PRs

@PVince81

PVince81 commented Oct 13, 2017

Copy link
Copy Markdown
Contributor

@PVince81

PVince81 commented Nov 3, 2017

Copy link
Copy Markdown
Contributor

@tomneedham did you add this on top of your backport PRs for stable9.1, stable9 ?

@PVince81

PVince81 commented Jan 8, 2018

Copy link
Copy Markdown
Contributor

Currently missing on stable9 and stable9.1.

Considering that stable9 is EOL and stable9.1 will be EOL in February, it might not be worth it. People should upgrade to 10 anyway. Removing backport label.

@lock

lock Bot commented Aug 1, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants