[WIP] Introducing metadata collections in dav by sharidas · Pull Request #29214 · owncloud/core

sharidas · 2017-10-12T04:49:03Z

This change is to have metadata collection
in dav app. This will help users to:

Create fileid with a UUID
Create subfolder "p" inside "meta" folder
Create subfolder "v" inside "meta" folder
The "p" folder stands for preview and "v"
folder stands for version.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Lets focus on versions for now

Related Issue

Todo

write behat tests to test dav api @Peter-Prochaska

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

DeepDiver1975 · 2017-10-12T07:48:33Z

+	 *
+	 * @param array $principalInfo
+	 */
+	public function __construct($principalInfo, IMetaData $metaData) {


there should be no principalInfo here - this collection is not user based

DeepDiver1975 · 2017-10-12T07:50:08Z

+use Sabre\DAVACL\AbstractPrincipalCollection;
+use Sabre\DAVACL\IPrincipal;
+
+class RootCollection extends AbstractPrincipalCollection {


no principal collection - there is no user involved.

we want 'meta/$fileid/v' not 'meta/$user/$fileId/v

DeepDiver1975 · 2017-10-12T07:53:53Z

+	 * @return MetaDataHome
+	 */
+	function getChildForPrincipal(array $principalInfo) {
+		$metaData = \OC::$server->getMetaData();


Please have a look at #29207

$metaNodeOfFile = \OC::$server->getRootFolder()->get("meta/{$info->getId()}/v");

PVince81 · 2017-10-12T08:21:18Z

+
+/**
+ * This class provides avatar functionality
+ * @since 6.0.0


this class will go away ... dont worry

PVince81 · 2017-10-12T08:21:23Z

+use OCP\Files\NotFoundException;
+
+/**
+ * This class provides avatar functionality


DeepDiver1975 · 2017-10-12T10:27:39Z

Removed. Got added to PR by mistake.

DeepDiver1975 · 2017-10-13T06:45:24Z

TODO:

try to move this to class Common

codecov · 2017-10-16T16:44:14Z

Codecov Report

Merging #29214 into master will increase coverage by 0.02%.
The diff coverage is 64.95%.

@@             Coverage Diff              @@
##             master   #29214      +/-   ##
============================================
+ Coverage     59.56%   59.59%   +0.02%     
- Complexity    17156    17291     +135     
============================================
  Files          1029     1038       +9     
  Lines         57211    57529     +318     
============================================
+ Hits          34076    34282     +206     
- Misses        23135    23247     +112

Impacted Files	Coverage Δ	Complexity Δ
lib/private/AvatarManager.php	`58.33% <ø> (-1.67%)`	`8 <0> (ø)`
apps/dav/lib/RootCollection.php	`100% <100%> (ø)`	`1 <0> (ø)`	⬇️
lib/private/Files/Storage/Local.php	`79.89% <100%> (ø)`	`86 <2> (ø)`	⬇️
lib/private/Files/Node/AbstractFile.php	`100% <100%> (ø)`	`6 <6> (?)`
apps/files_versions/lib/Storage.php	`69.12% <100%> (+0.08%)`	`103 <0> (ø)`	⬇️
lib/private/Files/Node/Root.php	`55.33% <100%> (+6.45%)`	`41 <3> (+4)`	⬆️
apps/dav/lib/MetaData/MetaDataNode.php	`28.57% <28.57%> (ø)`	`14 <14> (?)`
lib/private/Files/Meta/MetaRootNode.php	`28.94% <28.94%> (ø)`	`17 <17> (?)`
lib/private/Files/Meta/MetaFileIdNode.php	`32.5% <32.5%> (ø)`	`18 <18> (?)`
lib/private/Files/Meta/MetaVersionCollection.php	`75% <75%> (ø)`	`11 <11> (?)`
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59509e7...d9f799d. Read the comment docs.

DeepDiver1975 · 2017-10-17T06:48:17Z

DeepDiver1975 · 2017-10-17T06:48:42Z

~~name ignored?~~

DeepDiver1975 · 2017-10-17T06:49:08Z

DeepDiver1975 · 2017-10-17T06:49:43Z

as discussed - meta sub tree is read only

… the future

This change is to have metadata collection in dav app. This will help users to: 1) Create fileid with a UUID 2) Create subfolder "p" inside "meta" folder 3) Create subfolder "v" inside "meta" folder The "p" folder stands for preview and "v" folder stands for version. Signed-off-by: Sujith H <sharidasan@owncloud.com>

DeepDiver1975 · 2017-10-19T08:29:39Z

closing this in favor of #29281

lock · 2019-08-02T06:02:44Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

sharidas added the 2 - Developing label Oct 12, 2017

sharidas self-assigned this Oct 12, 2017

sharidas added this to the development milestone Oct 12, 2017

sharidas force-pushed the dav-changes-for-metadata branch 7 times, most recently from 0bb390a to 4d80d3f Compare October 12, 2017 07:45

DeepDiver1975 self-requested a review October 12, 2017 07:47

DeepDiver1975 requested changes Oct 12, 2017

View reviewed changes

PVince81 reviewed Oct 12, 2017

View reviewed changes

sharidas force-pushed the dav-changes-for-metadata branch 3 times, most recently from e4b2618 to db5f0ce Compare October 12, 2017 10:26

DeepDiver1975 reviewed Oct 12, 2017

View reviewed changes

sharidas force-pushed the dav-changes-for-metadata branch 9 times, most recently from e74c028 to d7afba9 Compare October 13, 2017 06:12

DeepDiver1975 reviewed Oct 13, 2017

View reviewed changes

Comment thread lib/private/Files/Storage/Local.php Outdated

DeepDiver1975 Oct 13, 2017

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

try to move this to class Common

sharidas force-pushed the dav-changes-for-metadata branch 2 times, most recently from 00f9a6d to ef5676f Compare October 13, 2017 07:19

PVince81 mentioned this pull request Oct 16, 2017

Add "fileids" virtual collection with file ids #28947

Closed

11 tasks

sharidas force-pushed the dav-changes-for-metadata branch 5 times, most recently from b9ba5c5 to f7b6cb4 Compare October 16, 2017 14:16

DeepDiver1975 requested changes Oct 17, 2017

View reviewed changes

sharidas force-pushed the dav-changes-for-metadata branch 2 times, most recently from 846fe03 to dd16f79 Compare October 17, 2017 09:57

DeepDiver1975 added 4 commits October 17, 2017 12:35

Introducing Abstract base implementations for node api interface

a1688f6

Introducing IVersionedStorage

ddb97ee

Adding meta data file tree to node api

edbd992

Minimalistic implementation of versions integration - needs change in…

d81f8a0

… the future

sharidas force-pushed the dav-changes-for-metadata branch 8 times, most recently from ce1c776 to de41350 Compare October 18, 2017 08:15

sharidas force-pushed the dav-changes-for-metadata branch from de41350 to d9f799d Compare October 18, 2017 08:16

DeepDiver1975 closed this Oct 19, 2017

DeepDiver1975 deleted the dav-changes-for-metadata branch October 19, 2017 08:29

ownclouders added the status/STALE label Dec 20, 2017

lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019

Uh oh!

Conversation

sharidas commented Oct 12, 2017 • edited by DeepDiver1975 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Todo

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Oct 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Oct 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 commented Oct 19, 2017

Uh oh!

lock Bot commented Aug 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sharidas commented Oct 12, 2017 •

edited by DeepDiver1975

Loading

codecov Bot commented Oct 16, 2017 •

edited

Loading

DeepDiver1975 Oct 17, 2017 •

edited

Loading