fix backend js loading error, issue https://github.com/owncloud/files…#29217
Merged
Conversation
|
|
PVince81
reviewed
Oct 12, 2017
| foreach ($scripts as $script) { | ||
| if (is_array($script)) { | ||
| list($appName, $script) = $script; | ||
| list($appName, $tmpScript) = $script; |
Contributor
There was a problem hiding this comment.
ohhh, so the problem is that we were somehow replacing the foreach variable ? great catch!
PVince81
added
p1-urgent
Contributor
|
@henry42 can you sign the CLA ? See the "Details" link on the "license/cla" row in the test results above |
|
Thank you. I have fixed it. I use 10.0.3.3 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
some backend scripts do not load right.
Related Issue
owncloud/files_external_dropbox#13
Motivation and Context
In some php version, modification of the array during list() execution (e.g. using list($a, $b) = $b) results in undefined behavior.