Lazy connect to federated share, not in storage constructor#29275
Merged
Conversation
PVince81
requested review from
DeepDiver1975,
butonic,
jvillafanez and
tomneedham
Codecov Report
@@ Coverage Diff @@
## master #29275 +/- ##
============================================
+ Coverage 59.56% 59.59% +0.03%
- Complexity 17156 17162 +6
============================================
Files 1029 1029
Lines 57211 57222 +11
============================================
+ Hits 34076 34100 +24
+ Misses 23135 23122 -13
Continue to review full report at Codecov.
|
jvillafanez
approved these changes
Oct 18, 2017
jvillafanez
left a comment
jvillafanez
left a comment
Member
There was a problem hiding this comment.
I can't find a better way to do this at this moment.
Don't connect directly to the remote share inside the storage constructor. Defer this to the lazy initialization routine, which will then correctly configure the remote root using the discovery manager.
PVince81
force-pushed
the
lazy-init-fedstorage
branch
from
b5ab7c6 to
8e3bece
Compare
DeepDiver1975
approved these changes
Oct 19, 2017
Member
|
backport? @PVince81 |
Contributor
Author
|
stable10: #29314 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't connect directly to the remote share inside the storage
constructor. Defer this to the lazy initialization routine, which will
then correctly configure the remote root using the discovery manager.
Related Issue
Ref #28763 (comment)
Motivation and Context
To avoid having to wait for time outs for not yet memcached federated share connections. This could slow down upgrade processes because setting up FS calls the constructor of storages.
Also would improve performance when no memcache is configured when setting up FS for operations not relevant to the federated share, where it would previously still construct the storage and trigger a network connection.
How Has This Been Tested?
I just retested that federated shares still work, unit test also works.
Screenshots (if appropriate):
Types of changes
Checklist: