[stable10] Call getFullPath only if its defined in storage#29360
Merged
Conversation
Call getFullPath only if its defined in storage. Else use mount point to resolve the full path. Signed-off-by: Sujith H <sharidasan@owncloud.com>
9 tasks
Codecov Report
@@ Coverage Diff @@
## stable10 #29360 +/- ##
==============================================
+ Coverage 58.43% 58.43% +<.01%
- Complexity 17707 17708 +1
==============================================
Files 1059 1059
Lines 59386 59387 +1
==============================================
+ Hits 34702 34703 +1
Misses 24684 24684
Continue to review full report at Codecov.
|
87 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call getFullPath only if its defined in storage.
Else use mount point to resolve the full path.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
This change adds getFullPath method to shared external storage file.
Related Issue
#29167
Motivation and Context
Same as described at #29337
How Has This Been Tested?
Recreated the issue with the steps mentioned above. After applying this change when the file is deleted, the log file doesn't spit the error message.
Screenshots (if appropriate):
Types of changes
Checklist: