Skip to content

[stable10] UI-tests set marionette to null#30114

Merged
individual-it merged 2 commits into
stable10from
stable10-ui-tests-marionette-fix
Feb 7, 2018
Merged

[stable10] UI-tests set marionette to null#30114
individual-it merged 2 commits into
stable10from
stable10-ui-tests-marionette-fix

Conversation

@individual-it

@individual-it individual-it commented Jan 12, 2018

Copy link
Copy Markdown
Member

backport of #30110 to stable10 plus bumping mink extension, see original PR #30033

@individual-it

Copy link
Copy Markdown
Member Author

It does not work in stable10, I guess the mink extension was not updated here.

@phil-davis

Copy link
Copy Markdown
Contributor

I think this backport is needed first:
https://github.com/owncloud/core/pull/30102/files
after 10.0.5 is sorted

@PVince81

Copy link
Copy Markdown
Contributor

@ownclouders rebase

@ownclouders

Copy link
Copy Markdown
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders

Copy link
Copy Markdown
Contributor

Automated rebase with GitMate.io was successful! 🎉

@ownclouders ownclouders force-pushed the stable10-ui-tests-marionette-fix branch from cba84a2 to 3dc8b21 Compare January 23, 2018 15:10
@codecov

codecov Bot commented Jan 23, 2018

Copy link
Copy Markdown

Codecov Report

Merging #30114 into stable10 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #30114      +/-   ##
==============================================
+ Coverage       61.17%   61.17%   +<.01%     
  Complexity      18087    18087              
==============================================
  Files            1067     1067              
  Lines           60066    60066              
==============================================
+ Hits            36747    36748       +1     
+ Misses          23319    23318       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 82.69% <0%> (+0.14%) 129% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b0f28...187d4b6. Read the comment docs.

@individual-it individual-it force-pushed the stable10-ui-tests-marionette-fix branch from 3dc8b21 to 846475f Compare February 6, 2018 09:22
@phil-davis

Copy link
Copy Markdown
Contributor

@individual-it All CI passing, so this looks good to merge. The mink extension version change does not impact production.

@individual-it individual-it merged commit 31165aa into stable10 Feb 7, 2018
@individual-it individual-it deleted the stable10-ui-tests-marionette-fix branch February 7, 2018 04:27
@lock

lock Bot commented Aug 1, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants