Skip to content

Bump PHP to 5.6.33 in composer#30401

Merged
phil-davis merged 1 commit into
masterfrom
bump-composer-php-5.6.33
Feb 7, 2018
Merged

Bump PHP to 5.6.33 in composer#30401
phil-davis merged 1 commit into
masterfrom
bump-composer-php-5.6.33

Conversation

@phil-davis

@phil-davis phil-davis commented Feb 7, 2018

Copy link
Copy Markdown
Contributor

Description

Bump PHP to 5.6.33 in composer.json

Related Issue

Motivation and Context

Before taking the plunge to PHP 7.1, might as well get master right up-to-date with the current PHP 5.6.33

How Has This Been Tested?

CI will tell

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis phil-davis added this to the development milestone Feb 7, 2018
@phil-davis phil-davis self-assigned this Feb 7, 2018
@phil-davis

Copy link
Copy Markdown
Contributor Author

This is a follow-on from #30242 and completes the obvious version bumps waiting to happen in master

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeepDiver1975

Copy link
Copy Markdown
Member

whats wrong with drone? only red all day long @patrickjahns

@phil-davis

Copy link
Copy Markdown
Contributor Author

I restarted the drone job for this. Some crud in "files" UI test suite. @individual-it made a PR for another page load timing issue today, and we will gradually find other places where we need to put more check-and-wait code into the UI tests.

@patrickjahns

Copy link
Copy Markdown
Contributor

@DeepDiver1975
Why does it not fail then? weird stuff

@DeepDiver1975

Copy link
Copy Markdown
Member

@DeepDiver1975 are you posting in the wrong PR?

yeah - too-many-open-tabs-hell

@codecov

codecov Bot commented Feb 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #30401 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30401      +/-   ##
============================================
+ Coverage     60.87%   60.88%   +<.01%     
  Complexity    18567    18567              
============================================
  Files          1093     1093              
  Lines         61324    61324              
============================================
+ Hits          37332    37335       +3     
+ Misses        23992    23989       -3
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 82.84% <0%> (+0.14%) 129% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 98.7% <0%> (+1.29%) 16% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd0de1...db21417. Read the comment docs.

@phil-davis phil-davis merged commit 85014de into master Feb 7, 2018
@phil-davis phil-davis deleted the bump-composer-php-5.6.33 branch February 7, 2018 18:02
@lock

lock Bot commented Aug 1, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants