Skip to content

Tidy error messages in acceptance tests run.sh#30679

Merged
individual-it merged 1 commit into
masterfrom
acceptance-test-app-enable-disable-messages
Mar 3, 2018
Merged

Tidy error messages in acceptance tests run.sh#30679
individual-it merged 1 commit into
masterfrom
acceptance-test-app-enable-disable-messages

Conversation

@phil-davis

@phil-davis phil-davis commented Mar 2, 2018

Copy link
Copy Markdown
Contributor

Description

Make each error message about "could not enable/disable..." unique and with text reflecting which function it happened in.

Related Issue

owncloud/QA#517
Followup of #30412 to tidy up bits I just noticed.

Motivation and Context

Make debugging easier when something goes wrong.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov

codecov Bot commented Mar 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #30679 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #30679   +/-   ##
=========================================
  Coverage     61.98%   61.98%           
  Complexity    19082    19082           
=========================================
  Files          1091     1091           
  Lines         61491    61491           
=========================================
  Hits          38114    38114           
  Misses        23377    23377

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8389096...57cfa8e. Read the comment docs.

@phil-davis

phil-davis commented Mar 3, 2018

Copy link
Copy Markdown
Contributor Author

Backport only easy/possible after #30412 is backported, and that is waiting for backport of #29669

Note: backported just the commit(s) related to this.

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport stable10 #30683

@individual-it individual-it merged commit be1c3e6 into master Mar 3, 2018
@individual-it individual-it deleted the acceptance-test-app-enable-disable-messages branch March 3, 2018 03:18
@lock

lock Bot commented Jul 31, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants