Skip to content

[stable10] Test unlock on exception during scanning#30847

Merged
DeepDiver1975 merged 4 commits into
stable10from
stable10-no-stray-lock-in-scanner-test-first
Mar 26, 2018
Merged

[stable10] Test unlock on exception during scanning#30847
DeepDiver1975 merged 4 commits into
stable10from
stable10-no-stray-lock-in-scanner-test-first

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Backport #30580

@codecov

codecov Bot commented Mar 21, 2018

Copy link
Copy Markdown

Codecov Report

Merging #30847 into stable10 will decrease coverage by <.01%.
The diff coverage is 94.28%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #30847      +/-   ##
==============================================
- Coverage       59.85%   59.85%   -0.01%     
+ Complexity      18257    18094     -163     
==============================================
  Files            1187     1187              
  Lines           71238    71236       -2     
  Branches         1244     1244              
==============================================
- Hits            42638    42635       -3     
- Misses          28228    28229       +1     
  Partials          372      372
Flag Coverage Δ Complexity Δ
#javascript 52.61% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 60.64% <94.28%> (-0.01%) 18094 <0> (-163)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/Temporary.php 100% <ø> (ø) 5 <0> (ø) ⬇️
lib/private/Files/Cache/Scanner.php 86.76% <94.28%> (-0.62%) 110 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86f7a4...0e8b1f1. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 8a73111 into stable10 Mar 26, 2018
@DeepDiver1975 DeepDiver1975 deleted the stable10-no-stray-lock-in-scanner-test-first branch March 26, 2018 14:03
@lock

lock Bot commented Jul 31, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants